From cd5dc461f6bff13c857854d9ed2af0ee279646d9 Mon Sep 17 00:00:00 2001
From: mae taylor <mae@mae.wtf>
Date: Wed, 23 Jul 2025 21:13:36 +0100
Subject: [PATCH] refactor: timeline into its own component fix: bug with
 last_post not clearing when changing

---
 src/lib/timeline.js                 |  5 ++
 src/lib/ui/timeline/Timeline.svelte | 78 +++++++++++++++++++++++++++++
 src/routes/+page.svelte             | 48 +-----------------
 3 files changed, 85 insertions(+), 46 deletions(-)
 create mode 100644 src/lib/ui/timeline/Timeline.svelte

diff --git a/src/lib/timeline.js b/src/lib/timeline.js
index 68aa2b2..179f0a4 100644
--- a/src/lib/timeline.js
+++ b/src/lib/timeline.js
@@ -71,3 +71,8 @@ export async function getTimeline(timelineType = "home", clean, localOnly = fals
     }
     loading = false;
 }
+
+export function clearTimeline() {
+    timeline.set([]);
+    last_post = false;
+}
\ No newline at end of file
diff --git a/src/lib/ui/timeline/Timeline.svelte b/src/lib/ui/timeline/Timeline.svelte
new file mode 100644
index 0000000..1053fef
--- /dev/null
+++ b/src/lib/ui/timeline/Timeline.svelte
@@ -0,0 +1,78 @@
+<script>
+    import { page } from '$app/stores';
+    import { account } from '$lib/stores/account.js';
+    import { timeline, getTimeline, clearTimeline } from '$lib/timeline.js';
+    import { app_name } from '$lib/config.js';
+    import Post from '$lib/ui/post/Post.svelte';
+    
+    import Lang from '$lib/lang';
+    const lang = Lang();
+
+    // TODO: refactor to enum when moving to TS
+    export let timelineType;
+
+    $: {
+        // awful hack to update timeline fresh
+        // when timelineType is updated
+        //
+        // TODO: migrate to $effect when migrating to svelte 5
+        timelineType = timelineType
+
+        clearTimeline()
+        getCurrentTimeline()
+    }
+
+    function getCurrentTimeline(clean = false) {
+        switch(timelineType) {
+            case "home":
+                getTimeline("home", clean);
+                break;
+
+            case "local":
+                getTimeline("public", clean, true)
+                break;
+
+            case "federated":
+                getTimeline("public", clean, false, true)
+                break;
+        }
+    }
+
+    account.subscribe(account => {
+        if (account) getCurrentTimeline();
+    });
+
+    document.addEventListener('scroll', () => {
+        if ($account && $page.url.pathname !== "/") return;
+        if (window.innerHeight + window.scrollY >= document.body.offsetHeight - 2048) {
+            getCurrentTimeline();
+        }
+    });
+</script>
+<div id="feed" role="feed">
+    {#if $timeline.length <= 0}
+        <div class="loading throb">
+            <span>{lang.string('timeline.fetching')}</span>
+        </div>
+    {/if}
+    {#each $timeline as post}
+        <Post post_data={post} />
+    {/each}
+</div>
+
+
+<style>
+    #feed {
+        margin-bottom: 20vh;
+    }
+
+    .loading {
+        width: 100%;
+        height: 80vh;
+        display: flex;
+        justify-content: center;
+        align-items: center;
+        font-size: 2em;
+        font-weight: bold;
+    }
+</style>
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index 3375ab4..5cae86d 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -9,6 +9,7 @@
     import Button from '$lib/ui/Button.svelte';
     import Post from '$lib/ui/post/Post.svelte';
     import PageHeader from '../lib/ui/core/PageHeader.svelte';
+    import Timeline from '../lib/ui/timeline/Timeline.svelte';
 
     const lang = Lang();
 
@@ -24,40 +25,7 @@
 
         // set in localStorage
         localStorage.setItem(app_name + '_selected_timeline', timelineType);
-     
-        // erase the timeline here so the ui reacts instantly
-        // mae: i could write an awesome undertale reference here
-        timeline.set([]);
-
-        getCurrentTimeline()
     }
-
-    function getCurrentTimeline(clean = false) {
-        switch(timelineType) {
-            case "home":
-                getTimeline("home", clean);
-                break;
-
-            case "local":
-                getTimeline("public", clean, true)
-                break;
-
-            case "federated":
-                getTimeline("public", clean, false, true)
-                break;
-        }
-    }
-
-    account.subscribe(account => {
-        if (account) getCurrentTimeline();
-    });
-
-    document.addEventListener('scroll', () => {
-        if ($account && $page.url.pathname !== "/") return;
-        if (window.innerHeight + window.scrollY >= document.body.offsetHeight - 2048) {
-            getCurrentTimeline();
-        }
-    });
 </script>
 
 {#if $account}
@@ -79,24 +47,12 @@
         </Button>
     </PageHeader>
 
-    <div id="feed" role="feed">
-        {#if $timeline.length <= 0}
-            <div class="loading throb">
-                <span>{lang.string('timeline.fetching')}</span>
-            </div>
-        {/if}
-        {#each $timeline as post}
-            <Post post_data={post} />
-        {/each}
-    </div>
+    <Timeline timelineType={timelineType}/>
 {:else}
     <LoginForm />
 {/if}
 
 <style>
-    #feed {
-        margin-bottom: 20vh;
-    }
 
     .loading {
         width: 100%;