MORE REFACTORING!! + some improvements

Signed-off-by: ari melody <ari@arimelody.me>

discord/discord.go

@@ -1,24 +1,45 @@
 package discord
 
 import (
-    "encoding/json"
-    "errors"
-    "fmt"
-    "net/http"
-    "net/url"
-    "strings"
+	"encoding/json"
+	"errors"
+	"fmt"
+	"net/http"
+	"net/url"
+	"os"
+	"strings"
 )
 
 const API_ENDPOINT = "https://discord.com/api/v10"
-const CLIENT_ID = "1268013769578119208"
 
-// TODO: good GOD change this later please i beg you. we've already broken
-// the rules by doing this at all
-const CLIENT_SECRET = "JUEZnixhN7BxmLIHmbECiKETMP85VT0E"
-const REDIRECT_URI = "https://discord.com/oauth2/authorize?client_id=1268013769578119208&response_type=code&redirect_uri=http%3A%2F%2F127.0.0.1%3A8080%2Fapi%2Fv1%2Fadmin%2Flogin&scope=identify"
-
-// TODO: change before prod
-const MY_REDIRECT_URI = "http://127.0.0.1:8080/api/v1/admin/login"
+var CLIENT_ID = func() string {
+    envvar := os.Getenv("DISCORD_CLIENT_ID")
+    if envvar == "" {
+        fmt.Printf("DISCORD_CLIENT_ID was not provided. Admin login will be unavailable.\n")
+    }
+    return envvar
+}()
+var CLIENT_SECRET = func() string {
+    envvar := os.Getenv("DISCORD_CLIENT_SECRET")
+    if envvar == "" {
+        fmt.Printf("DISCORD_CLIENT_SECRET was not provided. Admin login will be unavailable.\n")
+    }
+    return envvar
+}()
+var REDIRECT_URI = func() string {
+    envvar := os.Getenv("DISCORD_REDIRECT_URI")
+    if envvar == "" {
+        fmt.Printf("DISCORD_REDIRECT_URI was not provided. Admin login will be unavailable.\n")
+    }
+    return envvar
+}()
+var OAUTH_CALLBACK_URI = func() string {
+    envvar := os.Getenv("OAUTH_CALLBACK_URI")
+    if envvar == "" {
+        fmt.Printf("OAUTH_CALLBACK_URI was not provided. Admin login will be unavailable.\n")
+    }
+    return envvar
+}()
 
 type (
     AccessTokenResponse struct {
@@ -63,7 +84,7 @@ func GetOAuthTokenFromCode(code string) (string, error) {
         "client_secret": {CLIENT_SECRET},
         "grant_type":    {"authorization_code"},
         "code":          {code},
-        "redirect_uri":  {MY_REDIRECT_URI},
+        "redirect_uri":  {OAUTH_CALLBACK_URI},
     }.Encode()))
     req.Header.Add("Content-Type", "application/x-www-form-urlencoded")