more admin dashboard polish, some code cleanup

view/music.go

@@ -78,15 +78,15 @@ func ServeGateway(app *model.AppState, release *model.Release) http.Handler {
             }
         }
 
-        response := *release
-
-        if release.IsReleased() || privileged {
-            response.Tracks = release.Tracks
-            response.Credits = release.Credits
-            response.Links = release.Links
+        if !release.IsReleased() && !privileged {
+            release.Tracks = nil
+            release.Credits = nil
+            release.Links = nil
         }
 
-        err := templates.MusicGatewayTemplate.Execute(w, response)
+        for i, track := range release.Tracks { track.Number = i + 1 }
+
+        err := templates.MusicGatewayTemplate.Execute(w, release)
 
         if err != nil {
             fmt.Printf("Error rendering music gateway for %s: %s\n", release.ID, err)